CSL tests: copying CSL code into fixtures

One of the ratty aspects of the standard CSL test fixtures is that
many (77 of them) call external styles. For example:

https://bitbucket.org/bdarcus/citeproc-test/src/846e241d5875b25956f23f5bd8f4a7da73e88215/processor-tests/humans/bugreports_AllCapsLeakage.txt?at=default

The source of these styles is the test suite repo itself. They do not
change over time, so there is no real reason to store them separately.

As a first step toward cleaning up the suite, I would like to copy the
code of called styles into the fixtures themselves, so that each is
fully self-contained.

This shouldn’t affect the operation of test frameworks at all, but it
will a large check-in, so I thought I should run the plan past the
list before making the change. I have a script ready for the purpose,
but I’ll hold off in case anyone has reservations.

The fixtures could use a lot more work to make them more informative
and easier to work with, but this seems to be a good place to start.

Frank

Hi Frank,

I thought there were two advantages to this setup:

  • multiple tests can share a style (could be considered a problem, as modiyfing a style can affect multiple tests)
  • can reduce readbility of the tests when using very large styles

That said, I am not against it at all, just bringing up those 2 points just in case :slight_smile:

Best wishes,

Charles

Hi Frank,

I thought there were two advantages to this setup:

  • multiple tests can share a style (could be considered a problem, as modiyfing a style can affect multiple tests)

Yes. I’ll keep the code that reads in an external CSL file in my own
test runner, because it’s really handy for debugging. It’s just that
the distributed tests in the suite should be atomic. As you say, it
makes them more stable.

  • can reduce readbility of the tests when using very large styles

Yes. You do lose the convenience of a dedicated XML editor (until a
CSL test editor emerges …).